Skip to content

Commit

Permalink
[Lens]Show dynamic coloring only for metrics (#101777)
Browse files Browse the repository at this point in the history
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
dej611 and kibanamachine committed Jun 15, 2021
1 parent 92b6535 commit 65fec6b
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import React from 'react';
import { EuiButtonGroup, EuiComboBox, EuiFieldText } from '@elastic/eui';
import { FramePublicAPI, VisualizationDimensionEditorProps } from '../../types';
import { FramePublicAPI, Operation, VisualizationDimensionEditorProps } from '../../types';
import { DatatableVisualizationState } from '../visualization';
import { createMockDatasource, createMockFramePublicAPI } from '../../editor_frame_service/mocks';
import { mountWithIntl } from '@kbn/test/jest';
Expand Down Expand Up @@ -213,6 +213,22 @@ describe('data table dimension editor', () => {
expect(instance.find(PalettePanelContainer).exists()).toBe(true);
});

it('should not show the dynamic coloring option for a bucketed operation', () => {
frame.activeData!.first.columns[0].meta.type = 'number';
frame.datasourceLayers.first.getOperationForColumnId = jest.fn(
() => ({ isBucketed: true } as Operation)
);
state.columns[0].colorMode = 'cell';
const instance = mountWithIntl(<TableDimensionEditor {...props} />);

expect(instance.find('[data-test-subj="lnsDatatable_dynamicColoring_groups"]').exists()).toBe(
false
);
expect(instance.find('[data-test-subj="lnsDatatable_dynamicColoring_palette"]').exists()).toBe(
false
);
});

it('should show the summary field for non numeric columns', () => {
const instance = mountWithIntl(<TableDimensionEditor {...props} />);
expect(instance.find('[data-test-subj="lnsDatatable_summaryrow_function"]').exists()).toBe(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ export function TableDimensionEditor(
currentData
);

const datasource = frame.datasourceLayers[state.layerId];
const showDynamicColoringFeature = Boolean(
isNumeric && !datasource?.getOperationForColumnId(accessor)?.isBucketed
);

const visibleColumnsCount = state.columns.filter((c) => !c.hidden).length;

const hasTransposedColumn = state.columns.some(({ isTransposed }) => isTransposed);
Expand Down Expand Up @@ -260,7 +265,7 @@ export function TableDimensionEditor(
)}
</>
)}
{isNumeric && (
{showDynamicColoringFeature && (
<>
<EuiFormRow
display="columnCompressed"
Expand Down

0 comments on commit 65fec6b

Please sign in to comment.