Skip to content

Commit

Permalink
Removed unnecessary use of kbn-top-nav in dev tools app (wrapping tab…
Browse files Browse the repository at this point in the history
…s) (#39785)
  • Loading branch information
Liza Katz committed Jun 29, 2019
1 parent 2bf0618 commit 6165e19
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 25 deletions.
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/console/public/index.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<kbn-top-nav name="console" config="topNavMenu"></kbn-top-nav>
<kbn-dev-tools-app data-test-subj="console" top-nav-config="topNavController">
<kbn-dev-tools-app data-test-subj="console">
<sense-history ng-show="showHistory" is-shown="showHistory" history-dirty="lastRequestTimestamp"></sense-history>
<div class="conApp">
<div class="conApp__editor">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,22 @@
<div class="devApp app-container">
<kbn-top-nav name="devtools" config="kbnDevToolsApp.topNavConfig">
<!-- Transcluded elements. -->
<div data-transclude-slots>
<!-- Tabs. -->
<div data-transclude-slot="bottomRow" class="euiTabs" role="tablist">
<a
role="tab"
aria-selected="{{kbnDevToolsApp.currentPath === item.url}}"
ng-repeat="item in kbnDevToolsApp.devTools"
class="euiTab"
ng-class="{'euiTab-isSelected': kbnDevToolsApp.currentPath === item.url, 'euiTab-isDisabled': item.disabled}"
ng-disabled="item.disabled"
kbn-href="{{::item.url}}"
ng-click="kbnDevToolsApp.onClick(item, $event)"
tooltip="{{ item.tooltipContent }}"
tooltip-placement="bottom"
tooltip-popup-delay="0"
tooltip-append-to-body="1"
>
{{::item.display}}
</a>
</div>
</div>
</kbn-top-nav>
<!-- Tabs. -->
<div class="euiTabs" role="tablist">
<a
role="tab"
aria-selected="{{kbnDevToolsApp.currentPath === item.url}}"
ng-repeat="item in kbnDevToolsApp.devTools"
class="euiTab"
ng-class="{'euiTab-isSelected': kbnDevToolsApp.currentPath === item.url, 'euiTab-isDisabled': item.disabled}"
ng-disabled="item.disabled"
kbn-href="{{::item.url}}"
ng-click="kbnDevToolsApp.onClick(item, $event)"
tooltip="{{ item.tooltipContent }}"
tooltip-placement="bottom"
tooltip-popup-delay="0"
tooltip-append-to-body="1"
>
{{::item.display}}
</a>
</div>
<main class="devApp__container" role="tabpanel" ng-transclude></main>
</div>

0 comments on commit 6165e19

Please sign in to comment.