Only call addClickHandlers once

elastic · Jun 16, 2021 · 59196b6 · 59196b6
1 parent db2561d
commit 59196b6
Showing 1 changed file with 11 additions and 15 deletions.
diff --git a/x-pack/plugins/observability/public/hooks/use_breadcrumbs.ts b/x-pack/plugins/observability/public/hooks/use_breadcrumbs.ts
@@ -45,26 +45,22 @@ export const useBreadcrumbs = (extraCrumbs: ChromeBreadcrumb[]) => {
   } = useKibana();
   const setTitle = docTitle.change;
   const appPath = getUrlForApp('observability-overview') ?? '';
-  const navigate = navigateToUrl;
 
   useEffect(() => {
-    const breadcrumbs = addClickHandlers(
-      [
-        {
-          text: i18n.translate('xpack.observability.breadcrumbs.observabilityLinkText', {
-            defaultMessage: 'Observability',
-          }),
-          href: appPath + '/overview',
-        },
-        ...extraCrumbs,
-      ],
-      navigate
-    );
+    const breadcrumbs = [
+      {
+        text: i18n.translate('xpack.observability.breadcrumbs.observabilityLinkText', {
+          defaultMessage: 'Observability',
+        }),
+        href: appPath + '/overview',
+      },
+      ...extraCrumbs,
+    ];
     if (setBreadcrumbs) {
-      setBreadcrumbs(addClickHandlers(breadcrumbs, navigate));
+      setBreadcrumbs(addClickHandlers(breadcrumbs, navigateToUrl));
     }
     if (setTitle) {
       setTitle(getTitleFromBreadCrumbs(breadcrumbs));
     }
-  }, [appPath, extraCrumbs, navigate, params, setBreadcrumbs, setTitle]);
+  }, [appPath, extraCrumbs, navigateToUrl, params, setBreadcrumbs, setTitle]);
 };