wip

elastic · Jul 6, 2021 · 526aac3 · 526aac3
1 parent 4b07100
commit 526aac3
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 5 deletions.
diff --git a/...ns/security_solution/public/overview/components/overview_cti_links/cti_enabled_module.tsx b/...ns/security_solution/public/overview/components/overview_cti_links/cti_enabled_module.tsx
@@ -11,7 +11,9 @@ import { useCtiEventCounts } from '../../containers/overview_cti_links/use_cti_e
 import { CtiNoEvents } from './cti_no_events';
 import { CtiWithEvents } from './cti_with_events';
 
-export const CtiEnabledModuleComponent: React.FC<ThreatIntelLinkPanelProps> = (props) => {
+export const CtiEnabledModuleComponent: React.FC<
+  Omit<ThreatIntelLinkPanelProps, 'isThreatIntelModuleEnabled'>
+> = (props) => {
   const { eventCountsByDataset, totalCount } = useCtiEventCounts(props);
   const { to, from } = props;
 

diff --git a/...plugins/security_solution/public/overview/components/overview_cti_links/cti_no_events.tsx b/...plugins/security_solution/public/overview/components/overview_cti_links/cti_no_events.tsx
@@ -23,7 +23,7 @@ const warning = (
 
 export const CtiNoEventsComponent = ({ to, from }: { to: string; from: string }) => {
   const { buttonHref, listItems, isDashboardPluginDisabled } = useCtiDashboardLinks(
-    { ...emptyEventCountsByDataset },
+    emptyEventCountsByDataset,
     to,
     from
   );

diff --git a/...ugins/security_solution/public/overview/components/overview_cti_links/cti_with_events.tsx b/...ugins/security_solution/public/overview/components/overview_cti_links/cti_with_events.tsx
@@ -38,4 +38,12 @@ export const CtiWithEventsComponent = ({
 
 CtiWithEventsComponent.displayName = 'CtiWithEvents';
 
-export const CtiWithEvents = React.memo(CtiWithEventsComponent);
+export const CtiWithEvents = React.memo(
+  CtiWithEventsComponent,
+  (prevProps, nextProps) =>
+    prevProps.to === nextProps.to &&
+    prevProps.from === nextProps.from &&
+    prevProps.totalCount === nextProps.totalCount &&
+    JSON.stringify(prevProps.eventCountsByDataset) ===
+      JSON.stringify(nextProps.eventCountsByDataset)
+);
diff --git a/x-pack/plugins/security_solution/public/overview/components/overview_cti_links/index.tsx b/x-pack/plugins/security_solution/public/overview/components/overview_cti_links/index.tsx
@@ -32,4 +32,10 @@ const ThreatIntelLinkPanelComponent: React.FC<ThreatIntelLinkPanelProps> = (prop
 
 ThreatIntelLinkPanelComponent.displayName = 'ThreatIntelDashboardLinksComponent';
 
-export const ThreatIntelLinkPanel = React.memo(ThreatIntelLinkPanelComponent);
+export const ThreatIntelLinkPanel = React.memo(
+  ThreatIntelLinkPanelComponent,
+  (prevProps, nextProps) =>
+    prevProps.to === nextProps.to &&
+    prevProps.from === nextProps.from &&
+    prevProps.isThreatIntelModuleEnabled === nextProps.isThreatIntelModuleEnabled
+);
diff --git a/...s/security_solution/public/overview/containers/overview_cti_links/use_cti_event_counts.ts b/...s/security_solution/public/overview/containers/overview_cti_links/use_cti_event_counts.ts
@@ -18,7 +18,7 @@ export const useCtiEventCounts = ({
   from,
   setQuery,
   to,
-}: ThreatIntelLinkPanelProps) => {
+}: Omit<ThreatIntelLinkPanelProps, 'isThreatIntelModuleEnabled'>) => {
   const [isInitialLoading, setIsInitialLoading] = useState(true);
 
   const [loading, { data, inspect, totalCount, refetch }] = useRequestEventCounts(to, from);

diff --git a/x-pack/plugins/security_solution/public/overview/pages/overview.tsx b/x-pack/plugins/security_solution/public/overview/pages/overview.tsx
@@ -72,6 +72,7 @@ const OverviewComponent = () => {
   }, [addMessage]);
   const { allEnabled: isIngestEnabled } = useIngestEnabledCheck();
   const isThreatIntelModuleEnabled = useIsThreatIntelModuleEnabled();
+
   return (
     <>
       {indicesExist ? (