Skip to content

Commit

Permalink
[7.x] Fixed grammar (#74725) (#74745)
Browse files Browse the repository at this point in the history
* Fixed grammar (#74725)

# Conflicts:
#	rfcs/text/0001_lifecycle_setup.md

* Delete 0001_lifecycle_setup.md
  • Loading branch information
igoristic authored Aug 11, 2020
1 parent 173cae0 commit 4e9311f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion TYPESCRIPT.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ declare module '@elastic/eui' {
1. Open up the file and see how easy it would be to convert to TypeScript.
2. If it's very straightforward, go for it.
3. If it's not and you wish to stay focused on your own PR, get around the error by adding a type definition file in the same folder as the dependency, with the same name.
4. Minimally you will need to type what you are using in your PR. No need to go crazy to fully type the thing or you might be there for awhile depending on what's available.
4. Minimally you will need to type what you are using in your PR. No need to go crazy to fully type the thing or you might be there for a while depending on what's available.

For example:

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/data/public/search/search_interceptor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export class SearchInterceptor {
if (this.longRunningToast) return;
this.longRunningToast = this.deps.toasts.addInfo(
{
title: 'Your query is taking awhile',
title: 'Your query is taking a while',
text: getLongQueryNotification({
application: this.deps.application,
}),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class EnhancedSearchInterceptor extends SearchInterceptor {
if (this.longRunningToast) return;
this.longRunningToast = this.deps.toasts.addInfo(
{
title: 'Your query is taking awhile',
title: 'Your query is taking a while',
text: getLongQueryNotification({
cancel: this.cancelPending,
runBeyondTimeout: this.runBeyondTimeout,
Expand Down

0 comments on commit 4e9311f

Please sign in to comment.