little cleanups

elastic · Nov 24, 2020 · 4d4a524 · 4d4a524
1 parent e7836e1
commit 4d4a524
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/x-pack/plugins/security_solution/server/endpoint/lib/policy/license_watch.ts b/x-pack/plugins/security_solution/server/endpoint/lib/policy/license_watch.ts
@@ -67,6 +67,7 @@ export class PolicyWatcher {
       return;
     }
 
+    // @todo: actually page and fetch them ALL
     try {
       packagePolicies = (
         await this.policyService.list(this.soClient, {

diff --git a/x-pack/plugins/security_solution/server/plugin.ts b/x-pack/plugins/security_solution/server/plugin.ts
@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { Observable, Subscription } from 'rxjs';
+import { Observable } from 'rxjs';
 import { first } from 'rxjs/operators';
 import { i18n } from '@kbn/i18n';
 import LRU from 'lru-cache';
@@ -128,7 +128,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
 
   private lists: ListPluginSetup | undefined; // TODO: can we create ListPluginStart?
   private licensing$!: Observable<ILicense>;
-  private policyWatcher: PolicyWatcher;
+  private policyWatcher?: PolicyWatcher;
 
   private manifestTask: ManifestTask | undefined;
   private exceptionsCache: LRU<string, Buffer>;
@@ -385,7 +385,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
     this.logger.debug('Stopping plugin');
     this.telemetryEventsSender.stop();
     this.endpointAppContextService.stop();
-    this.policyWatcher.stop();
+    this.policyWatcher?.stop();
     licenseService.stop();
   }
 }