fix tests and use buttons instead of links

elastic · Mar 6, 2020 · 4641454 · 4641454
1 parent 05367ec
commit 4641454
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/x-pack/plugins/advanced_ui_actions/public/components/action_wizard/action_wizard.test.tsx b/x-pack/plugins/advanced_ui_actions/public/components/action_wizard/action_wizard.test.tsx
@@ -5,7 +5,7 @@
  */
 
 import React from 'react';
-import { cleanup, fireEvent, render } from '@testing-library/react';
+import { cleanup, fireEvent, render } from '@testing-library/react/pure';
 import '@testing-library/jest-dom/extend-expect'; // TODO: this should be global
 import { TEST_SUBJ_ACTION_FACTORY_ITEM, TEST_SUBJ_SELECTED_ACTION_FACTORY } from './action_wizard';
 import {
@@ -19,8 +19,7 @@ import {
 // https://github.com/elastic/kibana/issues/59469
 afterEach(cleanup);
 
-// TEMP until https://github.com/elastic/kibana/pull/59445 is merged
-test.skip('Pick and configure action', () => {
+test('Pick and configure action', () => {
   const screen = render(
     <Demo actionFactories={[dashboardDrilldownActionFactory, urlDrilldownActionFactory]} />
   );
@@ -47,8 +46,7 @@ test.skip('Pick and configure action', () => {
   });
 });
 
-// TEMP until https://github.com/elastic/kibana/pull/59445 is merged
-test.skip('If only one actions factory is available then actionFactory selection is emitted without user input', () => {
+test('If only one actions factory is available then actionFactory selection is emitted without user input', () => {
   const screen = render(<Demo actionFactories={[urlDrilldownActionFactory]} />);
 
   // check that no factories are displayed to pick from

diff --git a/x-pack/plugins/advanced_ui_actions/public/components/action_wizard/action_wizard.tsx b/x-pack/plugins/advanced_ui_actions/public/components/action_wizard/action_wizard.tsx
@@ -12,7 +12,7 @@ import {
   EuiIcon,
   EuiSpacer,
   EuiText,
-  EuiKeyPadMenuItem,
+  EuiKeyPadMenuItemButton,
 } from '@elastic/eui';
 import { txtChangeButton } from './i18n';
 import './action_wizard.scss';
@@ -126,6 +126,7 @@ const SelectedActionFactory: React.FC<SelectedActionFactoryProps> = ({
     <div
       className="auaActionWizard__selectedActionFactoryContainer"
       data-test-subj={TEST_SUBJ_SELECTED_ACTION_FACTORY}
+      data-testid={TEST_SUBJ_SELECTED_ACTION_FACTORY}
     >
       <header>
         <EuiFlexGroup alignItems="center" gutterSize="s">
@@ -179,15 +180,16 @@ const ActionFactorySelector: React.FC<ActionFactorySelectorProps> = ({
   return (
     <EuiFlexGroup wrap>
       {actionFactories.map(actionFactory => (
-        <EuiKeyPadMenuItem
+        <EuiKeyPadMenuItemButton
           className="auaActionWizard__actionFactoryItem"
           key={actionFactory.type}
           label={actionFactory.displayName}
+          data-testid={TEST_SUBJ_ACTION_FACTORY_ITEM}
           data-test-subj={TEST_SUBJ_ACTION_FACTORY_ITEM}
           onClick={() => onActionFactorySelected(actionFactory)}
         >
           {actionFactory.iconType && <EuiIcon type={actionFactory.iconType} size="m" />}
-        </EuiKeyPadMenuItem>
+        </EuiKeyPadMenuItemButton>
       ))}
     </EuiFlexGroup>
   );