Merge branch 'master' into vega_test

elastic · Jul 17, 2020 · 426a6ba · 426a6ba
2 parents fbb20da + 6164037
commit 426a6ba
Show file tree

Hide file tree

Showing 163 changed files with 3,615 additions and 8,042 deletions.
diff --git a/.ci/Jenkinsfile_baseline_capture b/.ci/Jenkinsfile_baseline_capture
@@ -8,12 +8,12 @@ kibanaPipeline(timeoutMinutes: 120) {
     catchError {
       parallel([
         'oss-visualRegression': {
-          workers.ci(name: 'oss-visualRegression', size: 's', ramDisk: false) {
+          workers.ci(name: 'oss-visualRegression', size: 's-highmem', ramDisk: true) {
             kibanaPipeline.functionalTestProcess('oss-visualRegression', './test/scripts/jenkins_visual_regression.sh')(1)
           }
         },
         'xpack-visualRegression': {
-          workers.ci(name: 'xpack-visualRegression', size: 's', ramDisk: false) {
+          workers.ci(name: 'xpack-visualRegression', size: 's-highmem', ramDisk: true) {
             kibanaPipeline.functionalTestProcess('xpack-visualRegression', './test/scripts/jenkins_xpack_visual_regression.sh')(1)
           }
         },

diff --git a/.ci/pipeline-library/src/test/prChanges.groovy b/.ci/pipeline-library/src/test/prChanges.groovy
@@ -84,4 +84,17 @@ class PrChangesTest extends KibanaBasePipelineTest {
 
     assertFalse(prChanges.areChangesSkippable())
   }
+
+  @Test
+  void 'areChangesSkippable() with skippable changes that are in notSkippablePaths'() {
+    props([
+      githubPrs: [
+        getChanges: { [
+          [filename: 'docs/developer/architecture/code-exploration.asciidoc'],
+        ] },
+      ],
+    ])
+
+    assertFalse(prChanges.areChangesSkippable())
+  }
 }