Fixing type error

elastic · Jan 6, 2020 · 377fd2b · 377fd2b
1 parent 83b4d47
commit 377fd2b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/x-pack/legacy/plugins/lens/public/app_plugin/plugin.tsx b/x-pack/legacy/plugins/lens/public/app_plugin/plugin.tsx
@@ -118,9 +118,9 @@ export class AppPlugin {
             const lensUrl = `${getKibanaBasePathFromDashboardUrl(
               lastDashboardAbsoluteUrl
             )}/lens/edit/${id}`;
-            if (lensUrl) {
+            const dashboardUrlWithoutTime = getDashboardUrlWithoutTime(lastDashboardAbsoluteUrl);
+            if (lensUrl && dashboardUrlWithoutTime) {
               window.history.pushState({}, '', lensUrl);
-              const dashboardUrlWithoutTime = getDashboardUrlWithoutTime(lastDashboardAbsoluteUrl);
               const dashboardParsedUrl = addEmbeddableToDashboardUrl(
                 dashboardUrlWithoutTime,
                 id,

diff --git a/x-pack/legacy/plugins/lens/public/app_plugin/url_helper.ts b/x-pack/legacy/plugins/lens/public/app_plugin/url_helper.ts
@@ -66,7 +66,7 @@ export function addEmbeddableToDashboardUrl(
  * output: http://localhost:5601/lib/app/kibana#/dashboard?_g=(refreshInterval:(pause:!t,value:0))
  * @param url dashboard absolute url
  */
-export function getDashboardUrlWithoutTime(url: string | undefined): string {
+export function getDashboardUrlWithoutTime(url: string | undefined): string | null {
   if (!url) {
     return null;
   }