Fix refactoring issues in test files.

elastic · Jan 27, 2021 · 349db31 · 349db31
1 parent 73cf9ad
commit 349db31
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 19 deletions.
diff --git a/...ns/uptime/public/components/monitor/ping_list/columns/ping_timestamp/nav_buttons.test.tsx b/...ns/uptime/public/components/monitor/ping_list/columns/ping_timestamp/nav_buttons.test.tsx
@@ -15,8 +15,8 @@ describe('NavButtons', () => {
   beforeEach(() => {
     defaultProps = {
       maxSteps: 3,
-      stepNo: 2,
-      setStepNo: jest.fn(),
+      stepNumber: 2,
+      setStepNumber: jest.fn(),
       setIsImagePopoverOpen: jest.fn(),
     };
   });
@@ -36,8 +36,8 @@ describe('NavButtons', () => {
     fireEvent.click(nextButton);
 
     await waitFor(() => {
-      expect(defaultProps.setStepNo).toHaveBeenCalledTimes(1);
-      expect(defaultProps.setStepNo).toHaveBeenCalledWith(3);
+      expect(defaultProps.setStepNumber).toHaveBeenCalledTimes(1);
+      expect(defaultProps.setStepNumber).toHaveBeenCalledWith(3);
     });
   });
 
@@ -49,22 +49,23 @@ describe('NavButtons', () => {
     fireEvent.click(nextButton);
 
     await waitFor(() => {
-      expect(defaultProps.setStepNo).toHaveBeenCalledTimes(1);
-      expect(defaultProps.setStepNo).toHaveBeenCalledWith(1);
+      expect(defaultProps.setStepNumber).toHaveBeenCalledTimes(1);
+      expect(defaultProps.setStepNumber).toHaveBeenCalledWith(1);
     });
   });
 
   it('disables `next` button on final step', () => {
-    defaultProps.stepNo = 3;
+    defaultProps.stepNumber = 3;
 
     const { getByLabelText } = render(<NavButtons {...defaultProps} />);
 
+    // getByLabelText('Next step');
     expect(getByLabelText('Next step')).toHaveAttribute('disabled');
     expect(getByLabelText('Previous step')).not.toHaveAttribute('disabled');
   });
 
   it('disables `prev` button on final step', () => {
-    defaultProps.stepNo = 1;
+    defaultProps.stepNumber = 1;
 
     const { getByLabelText } = render(<NavButtons {...defaultProps} />);
 

diff --git a/...uptime/public/components/monitor/ping_list/columns/ping_timestamp/ping_timestamp.test.tsx b/...uptime/public/components/monitor/ping_list/columns/ping_timestamp/ping_timestamp.test.tsx
@@ -14,8 +14,8 @@ import * as observabilityPublic from '../../../../../../../observability/public'
 
 mockReduxHooks();
 
-jest.mock('../../../../../../observability/public', () => {
-  const originalModule = jest.requireActual('../../../../../../observability/public');
+jest.mock('../../../../../../../observability/public', () => {
+  const originalModule = jest.requireActual('../../../../../../../observability/public');
 
   return {
     ...originalModule,
@@ -107,7 +107,7 @@ describe('Ping Timestamp component', () => {
     const caption = getByText('Nov 26, 2020 10:28:56 AM');
     fireEvent.mouseEnter(caption);
 
-    const altText = `A full-size screenshot for this journey step's thumbnail.`;
+    const altText = `A larger version of the screenshot for this journey step's thumbnail.`;
 
     await waitFor(() => getByAltText(altText));
 

diff --git a/...me/public/components/monitor/ping_list/columns/ping_timestamp/step_image_caption.test.tsx b/...me/public/components/monitor/ping_list/columns/ping_timestamp/step_image_caption.test.tsx
@@ -17,8 +17,8 @@ describe('StepImageCaption', () => {
       captionContent: 'test caption content',
       imgSrc: 'http://sample.com/sampleImageSrc.png',
       maxSteps: 3,
-      setStepNo: jest.fn(),
-      stepNo: 2,
+      setStepNumber: jest.fn(),
+      stepNumber: 2,
       timestamp: '2020-11-26T15:28:56.896Z',
     };
   });
@@ -38,8 +38,8 @@ describe('StepImageCaption', () => {
     fireEvent.click(nextButton);
 
     await waitFor(() => {
-      expect(defaultProps.setStepNo).toHaveBeenCalledTimes(1);
-      expect(defaultProps.setStepNo).toHaveBeenCalledWith(3);
+      expect(defaultProps.setStepNumber).toHaveBeenCalledTimes(1);
+      expect(defaultProps.setStepNumber).toHaveBeenCalledWith(3);
     });
   });
 
@@ -51,22 +51,23 @@ describe('StepImageCaption', () => {
     fireEvent.click(nextButton);
 
     await waitFor(() => {
-      expect(defaultProps.setStepNo).toHaveBeenCalledTimes(1);
-      expect(defaultProps.setStepNo).toHaveBeenCalledWith(1);
+      expect(defaultProps.setStepNumber).toHaveBeenCalledTimes(1);
+      expect(defaultProps.setStepNumber).toHaveBeenCalledWith(1);
     });
   });
 
   it('disables `next` button on final step', () => {
-    defaultProps.stepNo = 3;
+    defaultProps.stepNumber = 3;
 
     const { getByLabelText } = render(<StepImageCaption {...defaultProps} />);
 
+    // getByLabelText('Next step');
     expect(getByLabelText('Next step')).toHaveAttribute('disabled');
     expect(getByLabelText('Previous step')).not.toHaveAttribute('disabled');
   });
 
   it('disables `prev` button on final step', () => {
-    defaultProps.stepNo = 1;
+    defaultProps.stepNumber = 1;
 
     const { getByLabelText } = render(<StepImageCaption {...defaultProps} />);