No guards b/c kibana{Branch,Version} have defaults

elastic · Jul 30, 2020 · 33a98da · 33a98da
1 parent 61abba4
commit 33a98da
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/x-pack/plugins/ingest_manager/server/services/app_context.ts b/x-pack/plugins/ingest_manager/server/services/app_context.ts
@@ -24,8 +24,8 @@ class AppContextService {
   private configSubject$?: BehaviorSubject<IngestManagerConfigType>;
   private savedObjects: SavedObjectsServiceStart | undefined;
   private isProductionMode: IngestManagerAppContext['isProductionMode'] = false;
-  private kibanaVersion: IngestManagerAppContext['kibanaVersion'] | undefined = packageJSON.version;
-  private kibanaBranch: IngestManagerAppContext['kibanaBranch'] | undefined = packageJSON.branch;
+  private kibanaVersion: IngestManagerAppContext['kibanaVersion'] = packageJSON.version;
+  private kibanaBranch: IngestManagerAppContext['kibanaBranch'] = packageJSON.branch;
   private cloud?: CloudSetup;
   private logger: Logger | undefined;
   private httpSetup?: HttpServiceSetup;
@@ -122,16 +122,10 @@ class AppContextService {
   }
 
   public getKibanaVersion() {
-    if (!this.kibanaVersion) {
-      throw new Error('Kibana version is not set.');
-    }
     return this.kibanaVersion;
   }
 
   public getKibanaBranch() {
-    if (!this.kibanaBranch) {
-      throw new Error('Kibana branch is not set.');
-    }
     return this.kibanaBranch;
   }