Skip to content

Commit

Permalink
chore(NA): support yarn install using bazel managed directories for d…
Browse files Browse the repository at this point in the history
…ependencies (#89883) (#89983)

* chore(NA): allow yarn dependencies to be installed when using bazel to manage yarn deps

* chore(NA): remove unused flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
mistic and kibanamachine authored Feb 2, 2021
1 parent 596479a commit 332c9c1
Showing 1 changed file with 27 additions and 24 deletions.
51 changes: 27 additions & 24 deletions preinstall_check.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,37 @@
* Public License, v 1.
*/

const isUsingNpm = process.env.npm_config_git !== undefined;
(() => {
const isUsingNpm = process.env.npm_config_git !== undefined;

if (isUsingNpm) {
throw `Use Yarn instead of npm, see Kibana's contributing guidelines`;
}

// The value of the `npm_config_argv` env for each command:
//
// - `npm install`: '{"remain":[],"cooked":["install"],"original":[]}'
// - `yarn`: '{"remain":[],"cooked":["install"],"original":[]}'
// - `yarn kbn bootstrap`: '{"remain":[],"cooked":["run","kbn"],"original":["kbn","bootstrap"]}'
const rawArgv = process.env.npm_config_argv;

if (rawArgv === undefined) {
return;
}
if (isUsingNpm) {
throw `Use Yarn instead of npm, see Kibana's contributing guidelines`;
}

try {
const argv = JSON.parse(rawArgv);
// The value of the `npm_config_argv` env for each command:
//
// - `npm install`: '{"remain":[],"cooked":["install"],"original":[]}'
// - `yarn`: '{"remain":[],"cooked":["install"],"original":[]}'
// - `yarn kbn bootstrap`: '{"remain":[],"cooked":["run","kbn"],"original":["kbn","bootstrap"]}'
const rawArgv = process.env.npm_config_argv;

if (argv.cooked.includes('kbn')) {
// all good, trying to install deps using `kbn`
if (rawArgv === undefined) {
return;
}

if (argv.cooked.includes('install')) {
console.log('\nWARNING: When installing dependencies, prefer `yarn kbn bootstrap`\n');
try {
const argv = JSON.parse(rawArgv);

// allow dependencies to be installed with `yarn kbn bootstrap` or `bazel run @nodejs//:yarn` (called under the hood by bazel)
if (argv.cooked.includes('kbn') || !!process.env.BAZEL_YARN_INSTALL) {
// all good, trying to install deps using `kbn` or bazel directly
return;
}

if (argv.cooked.includes('install')) {
console.log('\nWARNING: When installing dependencies, prefer `yarn kbn bootstrap`\n');
}
} catch (e) {
// if it fails we do nothing, as this is just intended to be a helpful message
}
} catch (e) {
// if it fails we do nothing, as this is just intended to be a helpful message
}
})();

0 comments on commit 332c9c1

Please sign in to comment.