Skip to content

Commit

Permalink
[TSVB] Y-axis has number formatting not considering all series format…
Browse files Browse the repository at this point in the history
…ters in the group
  • Loading branch information
DianaDerevyankina committed Nov 16, 2020
1 parent 3ba7758 commit 1a0e740
Showing 1 changed file with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ export class TimeseriesVisualization extends Component {
const yAxis = [];
let mainDomainAdded = false;

const allSeriesHavePercentFormatter = seriesModel.every(
(seriesGroup) => seriesGroup.formatter === 'percent'
);

this.showToastNotification = null;

seriesModel.forEach((seriesGroup) => {
Expand Down Expand Up @@ -197,6 +201,10 @@ export class TimeseriesVisualization extends Component {
seriesDataRow.useDefaultGroupDomain = !isCustomDomain;
});

const tickFormatter = allSeriesHavePercentFormatter
? this.yAxisStackedByPercentFormatter
: (val) => val;

if (isCustomDomain) {
TimeseriesVisualization.addYAxis(yAxis, {
domain,
Expand All @@ -211,7 +219,7 @@ export class TimeseriesVisualization extends Component {
});
} else if (!mainDomainAdded) {
TimeseriesVisualization.addYAxis(yAxis, {
tickFormatter: series.length === 1 ? undefined : (val) => val,
tickFormatter: series.length === 1 ? undefined : tickFormatter,
id: yAxisIdGenerator('main'),
groupId: mainAxisGroupId,
position: model.axis_position,
Expand Down

0 comments on commit 1a0e740

Please sign in to comment.