Use data test subj selectors to find search box.

elastic · May 14, 2020 · 1244952 · 1244952
1 parent 885869e
commit 1244952
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 7 deletions.
diff --git a/...s_cluster_replication/public/__jest__/client_integration/auto_follow_pattern_list.test.js b/...s_cluster_replication/public/__jest__/client_integration/auto_follow_pattern_list.test.js
@@ -62,6 +62,7 @@ describe('<AutoFollowPatternList />', () => {
   });
 
   describe('when there are multiple pages of auto-follow patterns', () => {
+    let find;
     let component;
     let table;
     let actions;
@@ -81,7 +82,7 @@ describe('<AutoFollowPatternList />', () => {
       httpRequestsMockHelpers.setLoadAutoFollowPatternsResponse({ patterns: autoFollowPatterns });
 
       // Mount the component
-      ({ component, table, actions, form } = setup());
+      ({ find, component, table, actions, form } = setup());
 
       await nextTick(); // Make sure that the http request is fulfilled
       component.update();
@@ -97,7 +98,7 @@ describe('<AutoFollowPatternList />', () => {
     });
 
     test('search works', () => {
-      form.setInputValue(component.find('input[type="search"]'), 'unique');
+      form.setInputValue(find('autoFollowPatternSearch'), 'unique');
       const { tableCellsValues } = table.getMetaData('autoFollowPatternListTable');
       expect(tableCellsValues.length).toBe(1);
     });

diff --git a/...ross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js b/...ross_cluster_replication/public/__jest__/client_integration/follower_indices_list.test.js
@@ -68,6 +68,7 @@ describe('<FollowerIndicesList />', () => {
   });
 
   describe('when there are multiple pages of follower indices', () => {
+    let find;
     let component;
     let table;
     let actions;
@@ -91,7 +92,7 @@ describe('<FollowerIndicesList />', () => {
       httpRequestsMockHelpers.setLoadFollowerIndicesResponse({ indices: followerIndices });
 
       // Mount the component
-      ({ component, table, actions, form } = setup());
+      ({ find, component, table, actions, form } = setup());
 
       await nextTick(); // Make sure that the http request is fulfilled
       component.update();
@@ -107,7 +108,7 @@ describe('<FollowerIndicesList />', () => {
     });
 
     test('search works', () => {
-      form.setInputValue(component.find('input[type="search"]'), 'unique');
+      form.setInputValue(find('followerIndexSearch'), 'unique');
       const { tableCellsValues } = table.getMetaData('followerIndexListTable');
       expect(tableCellsValues.length).toBe(1);
     });

diff --git a/...uto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js b/...uto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js
@@ -336,6 +336,7 @@ export class AutoFollowPatternTable extends PureComponent {
       onChange: this.onSearch,
       box: {
         incremental: true,
+        'data-test-subj': 'autoFollowPatternSearch',
       },
     };
 

diff --git a/...ns/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js b/...ns/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js
@@ -318,6 +318,7 @@ export class FollowerIndicesTable extends PureComponent {
       onChange: this.onSearch,
       box: {
         incremental: true,
+        'data-test-subj': 'followerIndexSearch',
       },
     };
 

diff --git a/x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_list.test.js b/x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_list.test.js
@@ -70,11 +70,11 @@ describe('<RemoteClusterList />', () => {
   });
 
   describe('when there are multiple pages of remote clusters', () => {
+    let find;
     let table;
     let actions;
     let waitFor;
     let form;
-    let component;
 
     const remoteClusters = [
       {
@@ -94,7 +94,7 @@ describe('<RemoteClusterList />', () => {
       httpRequestsMockHelpers.setLoadRemoteClustersResponse(remoteClusters);
 
       await act(async () => {
-        ({ component, table, actions, waitFor, form } = setup());
+        ({ find, table, actions, waitFor, form } = setup());
         await waitFor('remoteClusterListTable');
       });
     });
@@ -109,7 +109,7 @@ describe('<RemoteClusterList />', () => {
     });
 
     test('search works', () => {
-      form.setInputValue(component.find('input[type="search"]'), 'unique');
+      form.setInputValue(find('remoteClusterSearch'), 'unique');
       const { tableCellsValues } = table.getMetaData('remoteClusterListTable');
       expect(tableCellsValues.length).toBe(1);
     });

diff --git a/...lic/application/sections/remote_cluster_list/remote_cluster_table/remote_cluster_table.js b/...lic/application/sections/remote_cluster_list/remote_cluster_table/remote_cluster_table.js
@@ -333,6 +333,7 @@ export class RemoteClusterTable extends Component {
       onChange: this.onSearch,
       box: {
         incremental: true,
+        'data-test-subj': 'remoteClusterSearch',
       },
     };
-Original file line number
+Diff line change
@@ Expand Up / @@ -336,6 +336,7 @@ export class AutoFollowPatternTable extends PureComponent { @@
           onChange: this.onSearch,
           box: {
             incremental: true,
+            'data-test-subj': 'autoFollowPatternSearch',
           },
         };
@@ Expand Down @@