Changed lens and visualize to use navigateToApp when returning to a n…

…on-dashboard originating app
elastic · May 12, 2020 · 0f581df · 0f581df
1 parent e481dc1
commit 0f581df
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/plugins/visualize/public/application/editor/editor.js b/src/plugins/visualize/public/application/editor/editor.js
@@ -69,7 +69,7 @@ function VisualizeAppController($scope, $route, $injector, $timeout, kbnUrlState
     data: { query: queryService, indexPatterns },
     toastNotifications,
     chrome,
-    core: { docLinks, fatalErrors, uiSettings },
+    core: { docLinks, fatalErrors, uiSettings, application },
     I18nContext,
     setActiveUrl,
     visualizations,
@@ -684,8 +684,7 @@ function VisualizeAppController($scope, $route, $injector, $timeout, kbnUrlState
                   embeddableType: VISUALIZE_EMBEDDABLE_TYPE,
                 });
               } else {
-                const href = chrome.navLinks.get(lastAppType).url;
-                window.location.href = href;
+                application.navigateToApp(lastAppType);
               }
             } else if (savedVis.id === $route.current.params.id) {
               chrome.docTitle.change(savedVis.lastSavedTitle);

diff --git a/x-pack/plugins/lens/public/app_plugin/mounter.tsx b/x-pack/plugins/lens/public/app_plugin/mounter.tsx
@@ -70,11 +70,7 @@ export async function mountApp(
           embeddableType: LENS_EMBEDDABLE_TYPE,
         });
       } else {
-        const originatingAppLink = coreStart.chrome.navLinks.get(originatingApp);
-        if (!originatingAppLink || !originatingAppLink.url) {
-          throw new Error('Cannot get originating app url');
-        }
-        window.location.href = originatingAppLink.url;
+        coreStart.application.navigateToApp(originatingApp);
       }
     }
   };