more elite code

elastic · Jan 9, 2020 · 0e4a5a6 · 0e4a5a6
1 parent 31eddd3
commit 0e4a5a6
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/x-pack/plugins/endpoint/public/embeddables/resolver/store/data/selectors.ts b/x-pack/plugins/endpoint/public/embeddables/resolver/store/data/selectors.ts
@@ -102,18 +102,20 @@ function widthsOfProcessSubtrees(indexedProcessTree: IndexedProcessTree): Proces
   return widths;
 }
 
-// bet sean loves this
+/**
+ * TODO comments
+ */
 type ProcessWithWidthMetadata = {
   process: ProcessEvent;
   width: number;
 } & (
-  | ({
+  | {
       parent: ProcessEvent;
       parentWidth: number;
-    } & ( // TODO bolete this
-      | { isOnlyChild: true; firstChildWidth: null; lastChildWidth: null }
-      | { isOnlyChild: false; firstChildWidth: number; lastChildWidth: number }
-    ))
+      isOnlyChild: boolean;
+      firstChildWidth: number;
+      lastChildWidth: number;
+    }
   | {
       parent: null;
       /* Without a parent, there is no parent width */
@@ -272,9 +274,8 @@ function* levelOrderWithWidths(
       const siblings = indexedProcessTreeChildren(tree, parent);
       if (siblings.length === 1) {
         metadata.isOnlyChild = true;
-        // TODO, just make these === width
-        metadata.lastChildWidth = null;
-        metadata.firstChildWidth = null;
+        metadata.lastChildWidth = width;
+        metadata.firstChildWidth = width;
       } else {
         const firstChildWidth = widths.get(siblings[0]);
         const lastChildWidth = widths.get(siblings[0]);