Incorporate PR feedback

elastic · Jun 8, 2020 · 05cb9f4 · 05cb9f4
1 parent 33168cb
commit 05cb9f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/x-pack/plugins/uptime/server/lib/requests/search/refine_potential_matches.ts b/x-pack/plugins/uptime/server/lib/requests/search/refine_potential_matches.ts
@@ -62,7 +62,10 @@ export const fullyMatchingIds = (queryResult: any, statusFilter?: string) => {
       //
       // We just check if the timestamp is greater. Note this may match an incomplete check group
       // that has not yet sent a summary doc
-      if (latestStillMatchingSource['@timestamp'] >= latestSource['@timestamp']) {
+      if (
+        latestStillMatchingSource &&
+        latestStillMatchingSource['@timestamp'] >= latestSource['@timestamp']
+      ) {
         matched = true;
       }
       const checkGroup = latestSource.monitor.check_group;

diff --git a/x-pack/test/api_integration/apis/uptime/rest/monitor_states_generated.ts b/x-pack/test/api_integration/apis/uptime/rest/monitor_states_generated.ts
@@ -71,7 +71,6 @@ export default function ({ getService }: FtrProviderContext) {
         const url = getBaseUrl(dateRangeStart, dateRangeEnd) + `&filters=${filters}`;
         const apiResponse = await supertest.get(url);
         const nonSummaryRes = apiResponse.body;
-        // expect(JSON.stringify(nonSummaryRes)).to.eql("foo");
         expect(nonSummaryRes.summaries.length).to.eql(1);
       });