Skip to content

Commit

Permalink
Limit the height of the "view in context" container
Browse files Browse the repository at this point in the history
The `EuiModal` has a max-height setting. In chrome, content with a
bigger height got clipped instead of forced to this max-height.

To ensure this never happens, we also limit the height of the content to
the same `max-height` of the modal.
  • Loading branch information
afgomez authored and Alejandro Fernández Gómez committed Nov 11, 2020
1 parent 7e24ae6 commit 017912f
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ const LogInContextWrapper = euiStyled.div<{ width: number | string; height: numb
padding: 16px;
width: ${(props) => (typeof props.width === 'number' ? `${props.width}px` : props.width)};
height: ${(props) => (typeof props.height === 'number' ? `${props.height}px` : props.height)};
max-height: 75vh; // Same as EuiModal
`;

const LogEntryContext: React.FC<{ context: LogEntry['context'] }> = ({ context }) => {
Expand Down

0 comments on commit 017912f

Please sign in to comment.