Merge pull request #1639 from spenceralger/advanced_editting

Improve ux when editing advanced config default
elastic · Oct 10, 2014 · 00326b2 · 00326b2
2 parents 46a0815 + eecc21b
commit 00326b2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/kibana/apps/settings/sections/advanced/index.js b/src/kibana/apps/settings/sections/advanced/index.js
@@ -75,14 +75,18 @@ define(function (require) {
         };
 
         $scope.edit = function (conf) {
-          conf.unsavedValue = conf.value;
+          conf.unsavedValue = conf.value || conf.defVal;
           $scope.configs.forEach(function (c) {
             c.editting = (c === conf);
           });
         };
 
         $scope.save = function (conf) {
           loading(conf, function () {
+            if (conf.unsavedValue === conf.defVal) {
+              return config.clear(conf.name);
+            }
+
             return config.set(conf.name, conf.unsavedValue);
           });
         };