-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zeek] Make event.original optional #992
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
2fdc629
to
dbe1051
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
dbe1051
to
bbd4e3e
Compare
bbd4e3e
to
6269436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small nitpick, you could change the description for:
description: Drop if no Splunk or log data present.
To the fact that it only drops if the data is from Splunk, since there is no empty values from zeek directly.
* Make event.original optional * Change description
* Make event.original optional * Change description
What does this PR do?
Make event.original optional
Checklist
changelog.yml
file.Related issues
Screenshots