Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimecast: map SpamProcessingDetail as flattened #5524

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 13, 2023

What does this PR do?

Changes the mapping of SpamProcessingDetail to flattened.

This field is defined as an object in the Mimecast docs[1].

[1]https://integrations.mimecast.com/documentation/endpoint-reference/message-finder-formerly-tracking/get-message-info/

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:mimecast Mimecast labels Mar 13, 2023
@efd6 efd6 self-assigned this Mar 13, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-13T21:25:46.269+0000

  • Duration: 20 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 95.082% (116/122) 👍 68.415
Lines 88.678% (1261/1422) 👎 -11.322
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review March 13, 2023 21:47
@efd6 efd6 requested a review from a team as a code owner March 13, 2023 21:47
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 3fb1e14 into elastic:main Mar 14, 2023
@elasticmachine
Copy link

Package mimecast - 1.6.4 containing this change is available at https://epr.elastic.co/search?package=mimecast

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@efd6 efd6 deleted the s3176-mimecast branch February 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:mimecast Mimecast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants