Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Support Sysmon New EventIDs - 8, 9, 19, 20, 27, 28, 255 #5511

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Mar 10, 2023

What does this PR do?

Supports more Sysmon events introduced since v13.10. Following EventIDs are supported:

EventIDs: 8, 9, 19, 20, 27, 28, 255

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package stack down && elastic-package build && elastic-package stack up --version=8.6.0 -d -v --services=elasticsearch && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate --data-streams sysmon_operational -v

Run pipeline tests for the package
--- Test results for package: windows - START ---
╭─────────┬────────────────────┬───────────┬──────────────────┬────────┬──────────────╮
│ PACKAGE │ DATA STREAM        │ TEST TYPE │ TEST NAME        │ RESULT │ TIME ELAPSED │
├─────────┼────────────────────┼───────────┼──────────────────┼────────┼──────────────┤
│ windows │ sysmon_operational │ pipeline  │ test-events.json │ PASS   │ 253.876625ms │
╰─────────┴────────────────────┴───────────┴──────────────────┴────────┴──────────────╯
--- Test results for package: windows - END   ---
Done

Related issues

Screenshots

@kcreddy kcreddy added enhancement New feature or request Integration:windows Windows labels Mar 10, 2023
@kcreddy kcreddy self-assigned this Mar 10, 2023
@kcreddy kcreddy changed the title Support EventID 8,9,19,20 [Windows] Support Sysmon New EventIDs - 8, 9, 19, 20, 27, 28, 255 Mar 10, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-14T06:45:36.105+0000

  • Duration: 17 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -12.5
Classes 87.5% (7/8) 👎 -12.5
Methods 83.516% (76/91) 👎 -16.484
Lines 92.748% (5103/5502) 👎 -3.534
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy force-pushed the int-4038-win_sysmon_v13 branch 2 times, most recently from 517f762 to 38ce370 Compare March 12, 2023 10:48
@kcreddy kcreddy marked this pull request as ready for review March 12, 2023 12:40
@kcreddy kcreddy requested review from a team as code owners March 12, 2023 12:40
@kcreddy kcreddy requested review from ycombinator and cmacknz March 12, 2023 12:40
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy kcreddy force-pushed the int-4038-win_sysmon_v13 branch from 38ce370 to 5987b69 Compare March 12, 2023 12:43
@kcreddy kcreddy force-pushed the int-4038-win_sysmon_v13 branch from 5987b69 to 10f960b Compare March 14, 2023 06:45
@kcreddy kcreddy merged commit 4556514 into elastic:main Mar 14, 2023
@elasticmachine
Copy link

Package windows - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=windows

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@kcreddy kcreddy deleted the int-4038-win_sysmon_v13 branch February 7, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:windows Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sysmon] Full Event Coverage
3 participants