Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google_workspace] Add support for Alert Data Stream #3837

Merged
merged 12 commits into from
Nov 22, 2022
Merged

[google_workspace] Add support for Alert Data Stream #3837

merged 12 commits into from
Nov 22, 2022

Conversation

vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Jul 26, 2022 •
edited
Loading

What does this PR do?

  • Added a data stream.
  • Added data collection logic to the data stream.
  • Added the ingest pipeline for the data stream.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files
  • Added dashboards and visualizations.
  • Added test for pipeline for the data stream.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^8.4.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/google_workspace directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image
image
image
image
image

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner July 26, 2022 18:30
@vinit-chauhan vinit-chauhan changed the title Add New Alert Data Stream [google_workspace] Add New Alert Data Stream Jul 26, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@vinit-chauhan vinit-chauhan added the enhancement New feature or request label Jul 26, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 26, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-14T12:26:02.964+0000

  • Duration: 21 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 53
Skipped 0
Total 53

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 26, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (7/7) 💚 2.53
Classes 100.0% (7/7) 💚 2.53
Methods 100.0% (93/93) 💚 9.119
Lines 96.963% (2586/2667) 👍 5.267
Conditionals 100.0% (0/0) 💚

@jamiehynds jamiehynds mentioned this pull request Jul 28, 2022
Closed
15 tasks
@vinit-chauhan vinit-chauhan changed the title [google_workspace] Add New Alert Data Stream [google_workspace] Add support for Alert Data Stream Aug 5, 2022
@vinit-chauhan vinit-chauhan self-assigned this Aug 17, 2022
@jamiehynds jamiehynds mentioned this pull request Sep 7, 2022
Closed
8 tasks
@vinit-chauhan
Copy link
Contributor Author

/test

@marc-gr marc-gr self-requested a review September 20, 2022 14:17
@elasticmachine
Copy link

elasticmachine commented Sep 23, 2022 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@vinit-chauhan vinit-chauhan force-pushed the package_google_workspace branch from 50cb410 to 0260a62 Compare September 24, 2022 08:49
@vinit-chauhan vinit-chauhan mentioned this pull request Sep 26, 2022
Merged
15 tasks
@jamiehynds
Copy link

@andrewkroh @marc-gr can you confirm where we're at with this integration? It goes back to July, so hoping to get the review complete or get any changes required by Crest done ASAP. Thanks!

@marc-gr
Copy link
Contributor

marc-gr commented Oct 26, 2022 •
edited
Loading

@andrewkroh @marc-gr can you confirm where we're at with this integration? It goes back to July, so hoping to get the review complete or get any changes required by Crest done ASAP. Thanks!

last week we merged the required fix for the pagination to work (elastic/beats#33400), just waiting for a confirmation that it works for them and overall that would be it

@andrewkroh
Copy link
Member

From talking with @vinit-elastic there is one more issue found while testing the latest snapshot that affects the page number state. They will open a new issue for elastic/beats to track the problem and link it to the related integrations PRs.

@vinit-chauhan vinit-chauhan force-pushed the package_google_workspace branch from 88a81b3 to bd59a6f Compare November 10, 2022 06:57
@marc-gr marc-gr requested a review from andrewkroh November 14, 2022 12:13
@vinit-chauhan vinit-chauhan force-pushed the package_google_workspace branch from 2a9023a to 18a53a1 Compare November 14, 2022 12:18
@andrewkroh andrewkroh merged commit 5b99ba9 into elastic:main Nov 22, 2022
@elasticmachine
Copy link

Package google_workspace - 2.0.0 containing this change is available at https://epr.elastic.co

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@marc-gr marc-gr

@vinit-chauhan vinit-chauhan

Labels
enhancement New feature or request Epic Integration:google_workspace Google Workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Workspace Alerts Center
5 participants
@vinit-chauhan @elasticmachine @jamiehynds @marc-gr @andrewkroh