Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o365: add record types beyond 66 #3588

Merged
merged 1 commit into from
Jun 27, 2022
Merged

o365: add record types beyond 66 #3588

merged 1 commit into from
Jun 27, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 27, 2022

What does this PR do?

This extends the mapped record types up to the currently listed set.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:o365 Microsoft Office 365 labels Jun 27, 2022
@efd6 efd6 requested a review from a team as a code owner June 27, 2022 05:14
@efd6 efd6 self-assigned this Jun 27, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-27T05:20:53.080+0000

  • Duration: 18 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.555
Classes 100.0% (1/1) 💚 3.555
Methods 100.0% (15/15) 💚 10.688
Lines 82.054% (727/886) 👎 -8.782
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@r00tu53r r00tu53r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:o365 Microsoft Office 365
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants