Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated description on ssl node in manifest.yml to be uniform and link to online documentation for integrations owned by sec-windows-platform #12772

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StacieClark-Elastic
Copy link
Member

Proposed commit message

Updates description field on ssl node in manifest.yml. Description is consistent with other integrations. This issue tracks change to integration owned by sec-windows-platform

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Originally, we update the descriptions on all the files. This created some issues with so many teams needing to validate the files. This is currently a partial update with files that are owned by sec-windows-platform.

git diff main | grep description: | grep + | sort -u
results in the update fields for the ssl node description and the changelog.yml

Related issues

Link related issues below. Insert the issue link or reference after the word "Closes" if merging this should automatically close it.

@StacieClark-Elastic StacieClark-Elastic added Integration:windows Windows Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] bugfix Pull request that fixes a bug issue Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform] labels Feb 13, 2025
@StacieClark-Elastic StacieClark-Elastic self-assigned this Feb 13, 2025
Updates description field on ssl node in manifest.yml. Description is consistent with other integrations. This issue tracks change to integration owned by sec-windows-platform
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-sec-windows-platform-12710 branch from 967b264 to ba77842 Compare February 13, 2025 16:04
@StacieClark-Elastic StacieClark-Elastic marked this pull request as ready for review February 13, 2025 16:04
@StacieClark-Elastic StacieClark-Elastic requested review from a team as code owners February 13, 2025 16:04
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @StacieClark-Elastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:windows Windows Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation changes for SSL node for integrations owned by sec-windows-platform
3 participants