Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated description on ssl node in data_stream to be uniform and include links to online documentation for integrations owned by sec-deployment-and-devices #12753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StacieClark-Elastic
Copy link
Member

@StacieClark-Elastic StacieClark-Elastic commented Feb 12, 2025

Updated ssl node descriptions in data_streams owned by sec-deployment-and-devices. This commit updates or adds descriptions to the ssl node to be uniform and to include links to online documentation. One is co-owned by obs-infraobs-integrations.

Proposed commit message

Updated ssl node descriptions in data_streams owned by sec-deployment-and-devices. This commit updates or adds descriptions to the ssl node to be uniform and to include links to online documentation. One is co-owned by obs-infraobs-integrations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Originally, we update the descriptions on all the files. This created some issues with so many teams needing to validate the files. This is currently a partial update with files that are owned by sec-deployment-and-devices,
One is owned by bs-infraobs-integrations. As such the only verification would be to check that was what updates is uniform. Note that the metrics type datastream points to a metricbeat documentation while logs point to filebeat.

git diff main | grep description: | grep + | sort -u
results in the update fields for the ssl node description and the changelog.yml

Related issues

Updated descriptions on ssl node in data_stream manifest.yml files owned by sec-deployment-and-devices
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/update-ssl-option-descriptions-sec-deployment-and-devices-12701 branch from 6a7bad9 to 41e17d9 Compare February 12, 2025 18:38
@StacieClark-Elastic StacieClark-Elastic marked this pull request as ready for review February 12, 2025 18:40
@StacieClark-Elastic StacieClark-Elastic requested review from a team as code owners February 12, 2025 18:40
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

@StacieClark-Elastic StacieClark-Elastic added Integration:squid Squid Proxy Integration:sophos Sophos Integration:cef Common Event Format (CEF) Integration:panw Palo Alto Next-Gen Firewall Integration:imperva Imperva Integration:juniper_srx Juniper SRX Integration:checkpoint Check Point Integration:hashicorp_vault Hashicorp Vault Integration:cisco_nexus Cisco Nexus Integration:cisco_ios Cisco IOS Integration:cisco_ftd Cisco FTD Integration:cisco_asa Cisco ASA Integration:pfsense pfSense Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:citrix_waf Citrix Web App Firewall Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:cisco_aironet Cisco Aironet bugfix Pull request that fixes a bug issue Integration:tcp Custom TCP Logs Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Integration:citrix_adc Citrix ADC labels Feb 12, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Contributor

@mjwolf mjwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cef Common Event Format (CEF) Integration:checkpoint Check Point Integration:cisco_aironet Cisco Aironet Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD Integration:cisco_ios Cisco IOS Integration:cisco_nexus Cisco Nexus Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:citrix_adc Citrix ADC Integration:citrix_waf Citrix Web App Firewall Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs Integration:fortinet_fortimail Fortinet FortiMail Integration:fortinet_fortimanager Fortinet FortiManager Logs Integration:fortinet_fortiproxy Fortinet FortiProxy Integration:hashicorp_vault Hashicorp Vault Integration:imperva Imperva Integration:juniper_srx Juniper SRX Integration:panw Palo Alto Next-Gen Firewall Integration:pfsense pfSense Integration:proxysg Broadcom ProxySG Integration:qnap_nas QNAP NAS Integration:sophos Sophos Integration:squid Squid Proxy Integration:stormshield StormShield SNS Integration:syslog_router Syslog Router Integration:tcp Custom TCP Logs Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation changes for SSL node for integration owned by sec-deployment-and-devices
3 participants