-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prisma Cloud] Fix ingest pipeline processors with tags create_user_name_and_user_domain
and convert_ip_address_to_ip
that fails for some values
#12752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests for the behaviour.
These will do:
diff --git a/packages/prisma_cloud/data_stream/audit/_dev/test/pipeline/test-audit.log b/packages/prisma_cloud/data_stream/audit/_dev/test/pipeline/test-audit.log
index ed7b90bb7d..e6081ba1c3 100644
--- a/packages/prisma_cloud/data_stream/audit/_dev/test/pipeline/test-audit.log
+++ b/packages/prisma_cloud/data_stream/audit/_dev/test/pipeline/test-audit.log
@@ -1 +1,5 @@
-{"timestamp":1693819702240,"user":"john.user@google.com","ipAddress":"81.2.69.142","actionType":"LOGIN","resourceName":"john.user@google.com","action":"'john.user@google.com'(with role 'System Admin':'System Admin') logged in via access key.","resourceType":"Login","result":"fail"}
\ No newline at end of file
+{"timestamp":1693819702240,"user":"john.user@google.com","ipAddress":"81.2.69.142","actionType":"LOGIN","resourceName":"john.user@google.com","action":"'john.user@google.com'(with role 'System Admin':'System Admin') logged in via access key.","resourceType":"Login","result":"fail"}
+{"timestamp":1693819702240,"user":"john.user@google.com","ipAddress":"RedLock Internal IP","actionType":"LOGIN","resourceName":"john.user@google.com","action":"'john.user@google.com'(with role 'System Admin':'System Admin') logged in via access key.","resourceType":"Login","result":"fail"}
+{"timestamp":1693819702240,"user":"john.user@google.com","actionType":"LOGIN","resourceName":"john.user@google.com","action":"'john.user@google.com'(with role 'System Admin':'System Admin') logged in via access key.","resourceType":"Login","result":"fail"}
+{"timestamp":1693819702240,"user":"john.user","ipAddress":"81.2.69.142","actionType":"LOGIN","resourceName":"john.user@google.com","action":"'john.user@google.com'(with role 'System Admin':'System Admin') logged in via access key.","resourceType":"Login","result":"fail"}
+{"timestamp":1693819702240,"ipAddress":"81.2.69.142","actionType":"LOGIN","resourceName":"john.user@google.com","action":"'john.user@google.com'(with role 'System Admin':'System Admin') logged in via access key.","resourceType":"Login","result":"fail"}
packages/prisma_cloud/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/prisma_cloud/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
@efd6 thanks! just added the tests and made the suggested changes. |
/test |
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Package prisma_cloud - 2.0.1 containing this change is available at https://epr.elastic.co/package/prisma_cloud/2.0.1/ |
Proposed commit message
This commits fix a dissect processor that uses the pattern
%{user.name}@%{user.domain}
on the fielduser.email
, but the processor that creates the fielduser.email
does not have a conditional to check if the value is indeed an email.This also fix a convert processor the converts the field
json.ipAddress
into an IP Address, but this field sometimes is populate with a string value that makes reference to an internal IP Address used by Prisma Cloud.Checklist
changelog.yml
file.Related issues