Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS S3] Introduce start timestamp and ignore older timespan to AWS S3 based integrations #12645

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Feb 6, 2025

Proposed commit message

Introduce Ignore Older Timespan and Start Timestamp properties to integrations backed by AWS S3 input,

  • Ignore Older Timespan: Accepts a timespan in which entries are accepted for processing
  • Start Timestamp: Accepts a timestamp from which objects are accepted for processing

Configuring these properties allows S3 input to efficiently manage its internal registry. For example, setting Ignore Older Timespan to 2h makes the S3 input registry only track entries within the last 2 hours. Once entries are beyond the timespan, input can remove them from the registry, thus reducing memory consumption.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

Configuration rendered (Title matching existing format)

image

@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/s3-start-and-ignore-older-timestamps branch 3 times, most recently from 888b269 to 2540178 Compare February 7, 2025 18:02
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Feb 7, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@Kavindu-Dodan Kavindu-Dodan added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] label Feb 7, 2025
@Kavindu-Dodan Kavindu-Dodan marked this pull request as ready for review February 7, 2025 19:38
@Kavindu-Dodan Kavindu-Dodan requested review from a team as code owners February 7, 2025 19:38
@Kavindu-Dodan Kavindu-Dodan changed the title [AWS S3] Introduce start timestamp and ignore older duration to AWS S3 based integrations [AWS S3] Introduce start timestamp and ignore older timespan to AWS S3 based integrations Feb 7, 2025
@MichaelKatsoulis MichaelKatsoulis self-requested a review February 10, 2025 16:01
@agithomas
Copy link
Contributor

agithomas commented Feb 11, 2025

@Kavindu-Dodan , could you please consider backporting the beats changes so that we can bump up the package versions only to 8.16.5 instead of 8.18.0?

cc @zmoog

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider a backporting the Beats change to keep the min stack version in the 8.16.x series.

packages/aws/manifest.yml Outdated Show resolved Hide resolved
@Kavindu-Dodan
Copy link
Contributor Author

Kavindu-Dodan commented Feb 14, 2025

Pending backports to 8.16.x 1 (next - 8.16.5) & 8.17.x 2 (next - 8.17.3) tracks. I will update this PR accordingly

Footnotes

  1. https://github.com/elastic/beats/pull/42716

  2. https://github.com/elastic/beats/pull/42717

@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/s3-start-and-ignore-older-timestamps branch from 2540178 to 58cdb90 Compare February 14, 2025 21:23
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

# Conflicts:
#	packages/amazon_security_lake/changelog.yml
#	packages/amazon_security_lake/manifest.yml
#	packages/aws/changelog.yml
#	packages/canva/changelog.yml
#	packages/canva/manifest.yml
#	packages/cloudflare_logpush/changelog.yml
#	packages/cloudflare_logpush/manifest.yml
#	packages/f5_bigip/changelog.yml
#	packages/imperva_cloud_waf/changelog.yml
#	packages/imperva_cloud_waf/manifest.yml
#	packages/servicenow/changelog.yml
#	packages/servicenow/manifest.yml
#	packages/sublime_security/changelog.yml
#	packages/symantec_endpoint_security/changelog.yml
#	packages/symantec_endpoint_security/manifest.yml
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/s3-start-and-ignore-older-timestamps branch from 58cdb90 to 4f09456 Compare February 14, 2025 21:29
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
@elasticmachine
Copy link

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] Introduce ignore_older & start_timestamp
5 participants