Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Fix security pipeline to support string event.code #1090

Merged
merged 3 commits into from
Jun 4, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 4, 2021

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@marc-gr marc-gr added bug Something isn't working, use only for issues Team:Security-External Integrations labels Jun 4, 2021
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 4, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1090 updated

  • Start Time: 2021-06-04T16:12:14.455+0000

  • Duration: 17 min 28 sec

  • Commit: 1ac166d

Test stats 🧪

Test Results
Failed 0
Passed 118
Skipped 0
Total 118

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehinman leehinman merged commit c335d60 into elastic:master Jun 4, 2021
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
…#1090)

* Fix security pipeline to support string event.code


Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co>
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
…#1090)

* Fix security pipeline to support string event.code


Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants