[Nginx] Add SLO's with Nginx Package #10269
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| { | ||
| "attributes": { | ||
| "name": "Nginx Availability", | ||
| "description": "", | ||
| "indicator": { | ||
| "type": "sli.kql.custom", | ||
| "params": { | ||
| "index": "logs-nginx.*", | ||
| "filter": "", | ||
| "good": "http.response.status_code < 500", | ||
| "total": "http.response.status_code : *", | ||
| "timestampField": "@timestamp" | ||
| } | ||
| }, | ||
| "budgetingMethod": "occurrences", | ||
| "timeWindow": { | ||
| "duration": "7d", | ||
| "type": "rolling" | ||
| }, | ||
| "objective": { | ||
| "target": 0.99 | ||
| }, | ||
| "tags": [] | ||
| }, | ||
| "id": "nginx-9eb25600-a1f0-11e7-928f-5dbe6f6f5510", | ||
| "references": [], | ||
| "type": "slo" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| format_version: "3.3.0" | ||
|
There was a problem hiding this comment. @jsoriano - I have updated the version to 3.3.0 to test the behaviour and I am getting this error.
Can you suggest on how to test this change with the pre-release version? There was a problem hiding this comment. No released version of package spec contains this spec version, you will need to add a replace in the meantime, something like this: There was a problem hiding this comment. What is the There was a problem hiding this comment.
There was a problem hiding this comment. @jsoriano - Tried the above step and with the There was a problem hiding this comment. Looks good, yes, this should be enough for CI. If you want to use elastic-package locally with this dependency you can run it as There was a problem hiding this comment. Thanks @jsoriano!
There was a problem hiding this comment. Yeah, after updating go.mod all tests are executed, but you can ignore the ones not related to your package. There was a problem hiding this comment.
@jsoriano When is the next release of the package spec? There was a problem hiding this comment.
We release more or less on demand, and we have just released 3.2.1. Maybe we can release 3.2.2 soon with a couple of bugfixes. This release would also include 3.3.0 prerelease, what will allow to use SLOs in prerelease packages. |
||
| name: nginx | ||
| title: Nginx | ||
| version: "1.22.0" | ||
| description: Collect logs and metrics from Nginx HTTP servers with Elastic Agent. | ||
| type: integration | ||
| categories: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| errors: | ||
| exclude_checks: | ||
| - PSR00001 # References in dashboards. | ||
| - JSE00001 # Kibana version for saved tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muthu-mps I just want to verify if this version is correct
v3.2.1-0.20240626070810-2758f3ed9689There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsoriano If I understand correctly, this addition is temporary? I mean once the next package-spec is released, do we still need this change? Maybe we should exclude this change from git and just rely on running
go run github.com/elastic/elastic-package buildlocally to be able to test it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, With this version I am able to build the integrations successfully by adding SLO's. That means it is using the
package-specchange to add slo's.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is temporary to allow to run in CI till 3.3.0 is available. This PR cannot be merged till then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replace can be removed now, we have just released a version of
elastic-packagethat includes the technical preview of 3.3.0.