Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[meta] add config for backport #971

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Dec 10, 2020

This commit add the config file to manage backport PR using
https://github.com/sqren/backport

This commit add the config file to manage backport PR using
https://github.com/sqren/backport
@jmlrt jmlrt added the meta label Dec 10, 2020
@jmlrt jmlrt requested a review from a team December 10, 2020 11:55
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍
lmk how it goes.

@jmlrt
Copy link
Member Author

jmlrt commented Dec 10, 2020

Admin merging as the transient issues are not related.

@jmlrt jmlrt merged commit 4cf9271 into elastic:master Dec 10, 2020
@jmlrt jmlrt deleted the backport-config branch December 10, 2020 14:52
@jmlrt
Copy link
Member Author

jmlrt commented Dec 10, 2020

@sqren thanks for your help and review.

Can you tell me if we need to backport this PR so .backportrc.json exists in 6.8, 7.10 and 7.x branches or is it enough to have it in master branch?

@sorenlouv
Copy link
Member

While not required it's a good idea to have it on any branch a developer might checkout locally.
This is because when running the backport script it will look for the config locally, do if a user is on a branch without a config it won't work.

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 10, 2020
This commit add the config file to manage backport PR using
https://github.com/sqren/backport
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 10, 2020
This commit add the config file to manage backport PR using
https://github.com/sqren/backport
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Dec 10, 2020
This commit add the config file to manage backport PR using
https://github.com/sqren/backport
jmlrt added a commit that referenced this pull request Dec 10, 2020
This commit add the config file to manage backport PR using
https://github.com/sqren/backport
jmlrt added a commit that referenced this pull request Dec 10, 2020
This commit add the config file to manage backport PR using
https://github.com/sqren/backport
jmlrt added a commit that referenced this pull request Dec 10, 2020
This commit add the config file to manage backport PR using
https://github.com/sqren/backport
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Feb 12, 2021
@jmlrt jmlrt mentioned this pull request Feb 18, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants