Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[meta] upgrade test #907

Merged
merged 7 commits into from
Nov 20, 2020
Merged

[meta] upgrade test #907

merged 7 commits into from
Nov 20, 2020

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Nov 17, 2020

This PR is adding a new upgrade test for every chart.

This test is deploying the oldest release version of charts which can be upgraded to latest version, then upgrading using unreleased charts in the repo.

The goal is to detect when some PR is introducing a breaking change.

  • Note 1: An upgrade test is already existing for Elasticsearch but had been removed from master branch because upgrade from 7.x to Elasticsearch 8.0.0-SNAPSHOT used by master branch isn't working. The new test allows overriding the Docker image version used during upgrade so we can still test upgrade on master but use the latest 7.x Docker image instead of 8.0.0-SNAPSHOT.
  • Note 2: Metricbeat chart introduced a breaking change in [meta] Helm 3 #516 and can be upgraded from any previous version currently, so Metricbeat test is commented and should be uncommented after 7.10.0 release so we can check if new PR are introducing new breaking changes.

  • Note 3: Currently charts upgrade are only tested with default values and so cover a small part of charts codebase, we should update it to test optional resources (ie: enable service or ingress, ...).

Fix #396

This commit add a new test which deploy a 7.7.0 chart and upgrade it to
latest version.
@jmlrt jmlrt added the meta label Nov 17, 2020
@jmlrt jmlrt changed the title upgrade test [meta] upgrade test Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Nov 17, 2020
@jmlrt
Copy link
Member Author

jmlrt commented Nov 17, 2020

Failing tests are new transient issues not related to this PR.

@jmlrt jmlrt marked this pull request as ready for review November 17, 2020 20:40
@jmlrt jmlrt requested a review from a team November 17, 2020 20:40
helpers/matrix.yml Outdated Show resolved Hide resolved
elasticsearch/examples/upgrade/Makefile Show resolved Hide resolved
@jmlrt jmlrt requested a review from Conky5 November 19, 2020 08:43
@jmlrt
Copy link
Member Author

jmlrt commented Nov 19, 2020

Failing tests are still transient errors. @Conky5 PTAL 🙏

Copy link
Contributor

@Conky5 Conky5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⛴️

@jmlrt jmlrt merged commit cfd8e29 into elastic:master Nov 20, 2020
@jmlrt jmlrt deleted the upgrade-test branch November 20, 2020 11:30
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 20, 2020
This PR is adding a new upgrade test for every chart.

This test is deploying the oldest **release** version of charts which can be upgraded to latest version, then upgrading using unreleased charts in the repo.

The goal is to detect when some PR is introducing a breaking change.

- Note 1: An upgrade test is already existing for Elasticsearch but had been removed from master branch because upgrade from 7.x to Elasticsearch 8.0.0-SNAPSHOT used by master branch isn't working. The new test allows overriding the Docker image version used during upgrade so we can still test upgrade on master but use the latest 7.x Docker image instead of 8.0.0-SNAPSHOT.

* Note 2:  Metricbeat chart introduced a breaking change in elastic#516 and can be upgraded from any previous version currently, so Metricbeat test is commented and should be uncommented after 7.10.0 release so we can check if new PR are introducing new breaking changes.

* Note 3: Currently charts upgrade are only tested with default values and so cover a small part of charts codebase, we should update it to test optional resources (ie: enable service or ingress, ...).

Fix elastic#396
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 20, 2020
This PR is adding a new upgrade test for every chart.

This test is deploying the oldest **release** version of charts which can be upgraded to latest version, then upgrading using unreleased charts in the repo.

The goal is to detect when some PR is introducing a breaking change.

- Note 1: An upgrade test is already existing for Elasticsearch but had been removed from master branch because upgrade from 7.x to Elasticsearch 8.0.0-SNAPSHOT used by master branch isn't working. The new test allows overriding the Docker image version used during upgrade so we can still test upgrade on master but use the latest 7.x Docker image instead of 8.0.0-SNAPSHOT.

* Note 2:  Metricbeat chart introduced a breaking change in elastic#516 and can be upgraded from any previous version currently, so Metricbeat test is commented and should be uncommented after 7.10.0 release so we can check if new PR are introducing new breaking changes.

* Note 3: Currently charts upgrade are only tested with default values and so cover a small part of charts codebase, we should update it to test optional resources (ie: enable service or ingress, ...).

Fix elastic#396
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 20, 2020
This PR is adding a new upgrade test for every chart.

This test is deploying the oldest **release** version of charts which can be upgraded to latest version, then upgrading using unreleased charts in the repo.

The goal is to detect when some PR is introducing a breaking change.

- Note 1: An upgrade test is already existing for Elasticsearch but had been removed from master branch because upgrade from 7.x to Elasticsearch 8.0.0-SNAPSHOT used by master branch isn't working. The new test allows overriding the Docker image version used during upgrade so we can still test upgrade on master but use the latest 7.x Docker image instead of 8.0.0-SNAPSHOT.

* Note 2:  Metricbeat chart introduced a breaking change in elastic#516 and can be upgraded from any previous version currently, so Metricbeat test is commented and should be uncommented after 7.10.0 release so we can check if new PR are introducing new breaking changes.

* Note 3: Currently charts upgrade are only tested with default values and so cover a small part of charts codebase, we should update it to test optional resources (ie: enable service or ingress, ...).

Fix elastic#396
jmlrt added a commit that referenced this pull request Nov 20, 2020
jmlrt added a commit that referenced this pull request Nov 20, 2020
jmlrt added a commit that referenced this pull request Nov 20, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Feb 12, 2021
@jmlrt jmlrt mentioned this pull request Feb 18, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add upgrade test for every chart
2 participants