Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Add namespace parameter to the test function to NOTES.txt #517

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Add namespace parameter to the test function to NOTES.txt #517

merged 1 commit into from
Mar 19, 2020

Conversation

maksim-m
Copy link
Contributor

If the user copies the second command from the notes, he will get an error "Error: release: not found". This PR adds a namespace parameter to the test function.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 16, 2020

💚 CLA has been signed

@maksim-m
Copy link
Contributor Author

@cla-checker-service I signed it.

@jmlrt
Copy link
Member

jmlrt commented Mar 18, 2020

cla/check

@jmlrt
Copy link
Member

jmlrt commented Mar 18, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this PR

@jmlrt jmlrt merged commit cd7532d into elastic:master Mar 19, 2020
@maksim-m maksim-m deleted the patch-1 branch March 19, 2020 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants