Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Update logstash chart to support custom ports #505

Merged
merged 3 commits into from
Mar 9, 2020
Merged

Update logstash chart to support custom ports #505

merged 3 commits into from
Mar 9, 2020

Conversation

ChiefAlexander
Copy link
Contributor

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 2, 2020

💚 CLA has been signed

@ChiefAlexander
Copy link
Contributor Author

I've signed the CLA. Not sure how to rerun the check...

@jmlrt jmlrt self-requested a review March 6, 2020 12:00
@jmlrt jmlrt added the enhancement New feature or request label Mar 6, 2020
@jmlrt
Copy link
Member

jmlrt commented Mar 6, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ChiefAlexander,

Thanks for this PR.

LGTM, however I would prefer naming this values extraPorts to keep consistent with the others values prefixed by extra. WDYT?

Also, it would be great to add a python test for this feature. You can find an example for extra container feature here, tests can then be run with make test (see Testing).

I can create the test in another PR if you're not confortable with it.

@ChiefAlexander
Copy link
Contributor Author

@jmlrt Thanks for the review! I have made your suggested changes.

@jmlrt
Copy link
Member

jmlrt commented Mar 9, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test.
Some change to do to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/22.

logstash/tests/logstash_test.py Outdated Show resolved Hide resolved
Co-Authored-By: Julien Mailleret <julien.mailleret@elastic.co>
@jmlrt
Copy link
Member

jmlrt commented Mar 9, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt merged commit a0e8d77 into elastic:master Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants