Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] add support for loadBalancerSourceRanges #483

Merged
merged 4 commits into from
Feb 25, 2020
Merged

[elasticsearch] add support for loadBalancerSourceRanges #483

merged 4 commits into from
Feb 25, 2020

Conversation

ta-ando
Copy link
Contributor

@ta-ando ta-ando commented Feb 14, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
f6dc7d1, f59c231

Please, read and sign the above mentioned agreement if you want to contribute to this project

@jmlrt
Copy link
Member

jmlrt commented Feb 24, 2020

cla/check

@jmlrt
Copy link
Member

jmlrt commented Feb 24, 2020

jenkins test this please

jmlrt
jmlrt previously approved these changes Feb 24, 2020
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt
Copy link
Member

jmlrt commented Feb 24, 2020

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Feb 24, 2020

Hi @ta-ando,
Our lint-python test is failing.
Can you reformat the file with black to make the test pass?

@ta-ando
Copy link
Contributor Author

ta-ando commented Feb 25, 2020

Hi @jmlrt,
I reformat the test I wrote.

@ta-ando ta-ando requested a review from jmlrt February 25, 2020 01:19
@jmlrt
Copy link
Member

jmlrt commented Feb 25, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt jmlrt merged commit 29bbb33 into elastic:master Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants