[logstash] Add fullnameOverride setting

[morganchristiansson]

Added fullnameOverride to logstash by copy pasting from kibana/filebeat/metricbeat charts.

• Chart version not bumped (the versions are all bumped and released at the same time)
• README.md updated with any new values or changes
• Updated template tests in ${CHART}/tests/*.py
• Updated integration tests in ${CHART}/examples/*/test/goss.yaml

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[morganchristiansson]

This is for overriding the name of the logstash service and just generally better naming options than "logstash-logstash" and "logstash-main-main" allowed by setting nameOverride value today.

With fullnameOverride the logstash service object can be given any name

Please run the build in Jenkins as I did not run tests locally.

[jmlrt]

jenkins test this please

[dorkvodor]

Hiya! Can this be merged now?

[morganchristiansson]

I managed to run the tests locally and created PR #463 to fix incompatible attrs dependency error for make pytest.

I updated tests to remove checks that are not applicable for default logstash deployment and it's passing locally now.

Please re-run the jenkins tests

[jmlrt]

jenkins test this please

[jmlrt]

⛴

[jmlrt]

The last line volumes = ... doesn't seem to be used

[morganchristiansson]

Where I copied it from it was used for this check

    assert {
               'name': 'data',
               'hostPath': {
                   'path': '/var/lib/' + custom_name + '-default-data',
                   'type': 'DirectoryOrCreate'
               }
           } in volumes

I don't think we care about custom_name being in volume mount path... So I'm going to delete this.

I do care that logstash.fullname has correct value and is used as the name of the deployment, service, etc.

[morganchristiansson]

I rebased my branch on upstream/master, amended this change into the Update tests commit and force-pushed

[jmlrt]

⛴

[jmlrt]

jenkins test this please

[morganchristiansson]

Thanks! I assume this will be released in the next elastic-stack release? Current release is 7.5.2 so 7.5.3 and later will include this fix?

[jmlrt]

Yes, this will be released in the next one which should be 7.5.3 or 7.6.0.