Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[helm-tester] freeze all pip dependencies #309

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Oct 2, 2019

  • Freezing attrs to 19.1.0 fix TypeError: attrib() got an unexpected keyword argument 'convert' issue that we have with 19.2.0
  • Also freezing other dependencies for safety

Fix #308

- freezing attrs to 19.1.0 fix `TypeError: attrib() got an unexpected keyword argument 'convert'` issue that we have with 19.2.0
- also freezing other dependencies for safety
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmlrt jmlrt merged commit f459509 into elastic:master Oct 2, 2019
@jmlrt jmlrt deleted the freeze-attrs-dependency branch October 2, 2019 08:13
morganchristiansson added a commit to morganchristiansson/elastic-charts that referenced this pull request Jan 28, 2020
Updates requirements.txt same as elastic#309 did for helpers/helm-tester/requirements.txt

- freezing attrs to 19.1.0 fix `TypeError: attrib() got an unexpected keyword argument 'convert'` issue that we have with 19.2.0
morganchristiansson added a commit to morganchristiansson/elastic-charts that referenced this pull request Jan 28, 2020
Updates requirements.txt same as elastic#309 did for helpers/helm-tester/requirements.txt

- freezing attrs to 19.1.0 fix `TypeError: attrib() got an unexpected keyword argument 'convert'` issue that we have with 19.2.0
- also freezing other dependencies for safety
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Feb 6, 2020
Updates requirements.txt same as elastic#309 did for helpers/helm-tester/requirements.txt

- freezing attrs to 19.1.0 fix `TypeError: attrib() got an unexpected keyword argument 'convert'` issue that we have with 19.2.0
- also freezing other dependencies for safety
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Charts template testing is failing with TypeError: attrib() got an unexpected keyword argument 'convert'
2 participants