Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Automatically detect esMajorVersion for default image #206

Merged
merged 2 commits into from
Jul 8, 2019
Merged

[elasticsearch] Automatically detect esMajorVersion for default image #206

merged 2 commits into from
Jul 8, 2019

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented Jul 5, 2019 •
edited
Loading

Closes: #192

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@Crazybus Crazybus mentioned this pull request Jul 5, 2019
Closed
jordansissel
jordansissel previously approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@jordansissel jordansissel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I haven't tested this manually, but the added tests cover all the cases I could come up with.

@Crazybus
Copy link
Contributor Author

Crazybus commented Jul 8, 2019

but the added tests cover all the cases I could come up with.

I had to rebase because of a merge conflict. I also found a couple more test cases that were missing. Please take another look.

@Crazybus
Copy link
Contributor Author

Crazybus commented Jul 8, 2019

The CI failure is coming from the freshly merged metricbeat chart:

12:29:50 HTTP: http://six-master:9200/_search?q=metricset.name:state_deployment: Body: patterns not found: [metricbeat-6.8.1]

It seems like the testing is not always wait long enough for the actual data to start flowing in. I'll fix this up in a different PR.

@Crazybus Crazybus mentioned this pull request Jul 8, 2019
Merged
jordansissel
jordansissel approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@jordansissel jordansissel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New test cases look good 👍

@Crazybus Crazybus merged commit d307ebf into master Jul 8, 2019
@Crazybus Crazybus deleted the pick_a_number branch July 8, 2019 18:43
@Crazybus Crazybus mentioned this pull request Aug 6, 2019
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jordansissel jordansissel jordansissel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown setting [discovery.seed_hosts] elasticsearch 6.x
2 participants
@Crazybus @jordansissel