This repository has been archived by the owner on May 16, 2023. It is now read-only.
[kibana] Always set server.host to the docker default #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #156 The Kibana docker image comes with [server.host](https://github.com/elastic/kibana/blob/3a1d4ad0acd986f55b7da532878e842dd62a1237/src/dev/build/tasks/os_packages/docker_generator/templates/kibana_yml.template.js#L30) set in the default `kibana.yml`. This setting is needed to make sure that services and ingress work correctly. If someone overrides the kibana.yml with custom configuration this setting changes back to the kibana default which is `localhost`. This keeps the setting consistent for the default helm install with default values and for anyone customising `kibana.yml`
tylerjl
approved these changes
Jun 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #156
The Kibana docker image comes with
server.host
set in the default
kibana.yml. This setting is needed to make surethat services and ingress work correctly. If someone overrides the
kibana.yml with custom configuration this setting changes back to the
kibana default which is
localhost.This keeps the setting consistent for the default helm install with
default values and for anyone customising
kibana.yml${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml