This repository has been archived by the owner on May 16, 2023. It is now read-only.
[kibana] Explicitly set the targetPort to the defined http port #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #133 Before this it wasn't possible to change the service port to anything other than 5601. E.g. if the `service.port` was changed to `80` then the targetPort would also be set to 80 even though Kibana was listening on 5601.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Before this it wasn't possible to change the service port to anything
other than 5601. E.g. if the
service.portwas changed to80then thetargetPort would also be set to 80 even though Kibana was listening on
5601.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml