Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[7.x] [kibana] adding extra volumes and extra volume mounts #1247

Closed

Conversation

DilasserT
Copy link
Contributor

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Related to #557

Adding options to mount additionnal volumes with extraVolumes and extraVolumeMounts through values.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 9, 2021

💚 CLA has been signed

@DilasserT DilasserT closed this Jun 9, 2021
@DilasserT DilasserT reopened this Jun 9, 2021
Copy link
Contributor

@ebuildy ebuildy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@jmlrt
Copy link
Member

jmlrt commented Jun 23, 2021

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Jun 23, 2021

Hi @DilasserT, changes looks fine, however PR should target master branch with backport PR handled by Elastic maintainer. Can you reopen it to master branch?

@jmlrt jmlrt added enhancement New feature or request kibana labels Jun 23, 2021
@jmlrt
Copy link
Member

jmlrt commented Jun 23, 2021

Also some changes are required to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/1001.

Can you run black kibana/tests/kibana_test.py?

@DilasserT DilasserT closed this Jun 24, 2021
@ebuildy
Copy link
Contributor

ebuildy commented Jun 24, 2021 via email

@DilasserT
Copy link
Contributor Author

I will reopen on master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request kibana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants