Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

graceful termination handler for master nodes #119

Merged
merged 4 commits into from
May 3, 2019

Conversation

kimxogus
Copy link
Contributor

@kimxogus kimxogus commented May 2, 2019

Rewrote #108 with reference #63 (comment)

fixes #63 for all es versions!

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few minor tweaks. Apart from that this is looking fantastic! I tested it out and it is working exactly as expected!

Thank you again so much for your persistence in getting this working :)

elasticsearch/templates/statefulset.yaml Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Outdated Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Outdated Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Outdated Show resolved Hide resolved
@kimxogus
Copy link
Contributor Author

kimxogus commented May 3, 2019

Applied changes

@Crazybus
Copy link
Contributor

Crazybus commented May 3, 2019

jenkins test this please

@Crazybus
Copy link
Contributor

Crazybus commented May 3, 2019

build failed because of google storage failures (even with retries):

curl: (7) Failed to connect to 2607:f8b0:4001:c14::80: Cannot assign requested address
The command '/bin/sh -c curl --retry 5 -O https://storage.googleapis.com/kubernetes-helm/helm-v${HELM_VERSION}-linux-amd64.tar.gz &&     tar xfv helm-v${HELM_VERSION}-linux-amd64.tar.gz &&     mv linux-amd64/helm /usr/local/bin/ &&     rm -rf linux-amd64 &&     helm version --client' returned a non-zero code: 7

jenkins test this please

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you again so much for your persistence in working on this!

@Crazybus Crazybus merged commit 0e8cd11 into elastic:master May 3, 2019
@kimxogus kimxogus deleted the elasticsearch/master-sidecar branch May 3, 2019 12:56
@tetianakravchenko
Copy link

@kimxogus @Crazybus is this additional container needed for all versions? as I understand it should be fixed as mentioned #63 (comment), maybe it makes sense to introduce additional value and add this container optionally? wdyt?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow re-election when elected master pod is deleted
4 participants