-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on iOS #134
Fix build on iOS #134
Conversation
Headers taken from /Applications/Xcode11.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
ping @jeanregisser would you be open to signing that CLA? I guess this PR is blocked for that reason |
Yes I did follow the process and signed the document on DocuSign but somehow the bot didn’t update the status. I’ll retry today. |
Is there any update on this? |
We don't want to include and maintain Apple's headers in this project. Apple should add the necessary headers to their IOS SDK if they are meant to be used to IOS projects. I recommend using tags to exclude the use of gosigar from projects that need to compile for mobile. I think we would accept a patch to include I did check if the MacOS SDK would work unmodified, but, no, it did not work without cherry-picking particular files as this PR has done. Specifically some of the headers complain that The other issue I encountered is that
|
感谢你的支持,成功的解决了编译错误的问题,这个修复在 |
This PR fixes a compilation error on iOS as seen in ethereum/go-ethereum#20160
Unfortunately
libproc.h
is not included in the iOS SDK. The missing headers were taken from Xcode 11.3.1 (/Applications/Xcode11.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/
).Let me know what you think. Thanks.