Fix memory reporting on FreeBSD #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michbsd thanks for this PR, travis found some formatting errors, can you take a look? You can fix them with |
jsoriano
reviewed
Jun 7, 2018
sigar_freebsd.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| self.Free = uint64(val) |
There was a problem hiding this comment.
Is this value the number of pages? Free is expected to be in bytes, we should probably multiply here by pagesize.
There was a problem hiding this comment.
it's done later down:
self.Used = self.Total - (self.Free * pagesize)
There was a problem hiding this comment.
But I mean to store the size in bytes in self.Free, i.e:
self.Free = uint64(val) * pagesize
self.Free is the value that will be used at the end for the free memory metrics.
jsoriano
approved these changes
Jun 8, 2018
|
ping - any news on this? |
|
@michbsd merged, sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move (self *Mem) function from sigar_linux_common to sigar_linux