[8.18](backport #4472) Fix docker image build for FIPS variants #4502
+196
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Fix multiple -tags= flags occurances. Correct the resulting docker image that's created when FIPS is used. Add fips e2e test that verifies a binary. (cherry picked from commit c83472b)
|
michel-laterman
approved these changes
Feb 20, 2025
github-actions
bot
added
Team:Elastic-Agent-Control-Plane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Multiple
-tags=flags are used ifFIPSandSNAPSHOTare set.Correct the resulting docker image that's created when FIPS is used.
Add fips e2e test that verifies a binary.
How does this PR solve the problem?
Merge tags used for all
go buildcommands into a comma separated list.Change resulting docker base image to a fips enabled one.
Add e2e test that will run after a FIPS binary has been compiled, test will use
go versionto ensure the go binary has the expected FIPS indicators (build tag and expriement), and will check the binary's symbols (if present) forOpenSSL_version.Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry in./changelog/fragmentsusing the changelog toolThis is an automatic backport of pull request Fix docker image build for FIPS variants #4472 done by Mergify.