Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EuiColorPicker with an accessible, custom component #856

Closed
wants to merge 7 commits into from

Conversation

snide
Copy link
Contributor

@snide snide commented May 18, 2018

Fixes #853
Fixes #791
Fixes #790
Fixes #789

Replaces EuiColorPicker with a simpler system for color selection. The previous version was a simple wrapper around react-color so this removes that dependency.

TODO

  • Write some tests
  • Do a screen reader pass
  • Update docs for every variation (compressed, disabled...etc)
  • Make a swatchOnly version where you don't want to allow a hex input
  • Provide a null / transparent state
  • Add extraAction props for swatches and the input to allow + / - from the list if needed (canvas request)

@snide
Copy link
Contributor Author

snide commented May 18, 2018

Speaking with @w33ble, canvas wants some extraAction props and example code to extend it like so. Added it to my todo.

image

@snide
Copy link
Contributor Author

snide commented Apr 18, 2019

@thompsongl Were you forking this? Any reason to keep it up as a PR? Otherwise I'll close it out.

@thompsongl
Copy link
Contributor

We can close this. Any work I do that builds on this can cherry-pick.

@thompsongl thompsongl closed this Apr 18, 2019
@thompsongl thompsongl mentioned this pull request May 3, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants