docs(EuiEmptyPrompt): Fix missing icons in EUI+ docs #8488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #8312
This fixes icon rendering in EUI+ EuiEmptyPrompt docs. Utilizing both
iconType
andicon
props felt easiest to achieve what we want.QA
Please note that EuiEmptyPrompt guidelines use
renderToJSXString
, which is incompatible with Docusaurus and our Demo component when used in prod builds. Additionally, EuiPageTemplate's sidebar gets rendered incorrectly as reported here. These pages currently work only when running locally, which is unrelated to this PR.gh pr checkout <id> && yarn
yarn workspace @elastic/eui-website run build:workspaces
yarn workspace @elastic/eui-website run start