-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EUI+] Add missing guidelines #8309
[EUI+] Add missing guidelines #8309
Conversation
acdfd9f
to
ca0be91
Compare
ca0be91
to
2bc584d
Compare
Here's what I found 🙂 EuiEmptyPrompt’s Guidelines subpage
[1] [2]
EuiToast’s Guidelines subpage
[3]
EuiTour’s Guidelines subpageNo comments 👍 Form controls’ Guidelines subpage
[4]
Selection controls’ Guidelines subpage
[5]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @weronikaolejniczak for tackling this one!
The code looks perfect to me, but I found a few things looking at it from a user/designer perspective, I left them in this comment. Maybe some changes are intended, let me know.
I fixed whatever I could, some things I couldn't without going outside of the scope of this PR and I'd propose to fix them on another task 😄 EuiEmptyPrompt ❌This one... 💀 With a bit of styling I managed to fix the "image radios" (5b34e63). The preview I was not able to get it to work as expected, hence #8312. Do you have an idea how to fix it? I updated the link 👍🏻 (9052665) Screen.Recording.2025-02-12.at.15.32.12.movEuiToast ✅This one is super weird! 🤔 The danger buttons do have bigger font-size although the same There are no additional styles passed to them. Something must be influencing it from higher up? Do you have an idea what could be wrong? EDIT: @acstll found out that the issue is with Docusaurus applying paragraph styles to a text that is in newline. I created a ticket in M2 to come up with a meaningful fix for this: #8329 I updated the link 👍🏻 (0f0ae20) Form controls ✅I made the height of guideline panels equal and I changed some (incorrect) "don't" sections to "do" (925a1e4): Selection controls ✅I agree this table looks weird 👍🏻 What I found is that this is the responsive behavior of The code in: |
@weronikaolejniczak I agree we could fix these later on 👍 I'll take a quick look first at your comments for EuiEmptyPrompt and EuiToast first, and then re-run this locally for a final check 🤓 (btw the screenshots inside the |
@acstll ohhh, thanks for letting me know! 🙏🏻 I uploaded the screenshots first, put them into details and didn't bother to check if it works. Fixed by just using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 (or 2 small things) more 🙏 🙏 🙏
f67b4d3
to
7808a49
Compare
7808a49
to
8815898
Compare
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you very much @weronikaolejniczak 🙏
Summary
This PR adds the missing guidelines for several components:
EuiEmptyPrompt
,EuiToast
,EuiTour
, Form controls and Selection controls.QA
Compare the content of all pages between the old docs and the new docs:
Note
There are missing icons in
EuiEmptyPrompt
preview. It's been extracted to a separate task: #8312 that will be tackled by @tkajtoch.