Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing styles for euiKeyPadMenu #8294

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

ek-so
Copy link
Contributor

@ek-so ek-so commented Jan 27, 2025

Summary

This PR fixes an issue mentioned in issue #158. Based on the discussion there and also on Borealis new color token rules, the changes include:

  • Remapping of the colors that are supported both in Amsterdam and Borealis;
  • Conditionally adding different interactive states to Borealis only (Amsterdam remains the same).

Changes made for Borealis include:

  • Removed jumping animation on hover
  • Added background on hover in addition to underline
  • Used a hovered background for the item on click, when it's not selected yet
  • Removed shadow entirely

Showcasing:

Amsterdam
CleanShot 2025-01-27 at 10 27 04

Borealis
CleanShot 2025-01-27 at 10 35 07

QA:

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@ek-so ek-so changed the base branch from main to eui-theme/borealis January 27, 2025 09:18
@ek-so ek-so marked this pull request as ready for review January 27, 2025 09:48
@ek-so ek-so requested a review from a team as a code owner January 27, 2025 09:48
@tkajtoch tkajtoch self-requested a review January 29, 2025 13:13
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @ek-so

@ek-so ek-so requested a review from mgadewoll February 10, 2025 17:28
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍
Thanks for the updates! 🎉

@ek-so ek-so merged commit 6fc367a into elastic:eui-theme/borealis Feb 11, 2025
4 checks passed
@ek-so ek-so deleted the key-pad-menu-styles branch February 11, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants