[High Contrast Mode] Steps, timelines, and comment lists #8223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-height - lets us remove/clean up a bunch of CSS + memoize styles while here + update VRT while here - no meaningful regressions AFAICT
+ improve `disabled` visibility in Windows high contrast
- switch to pseudo elements and borders to allow rendering - I did rerun VRT for this step but apparently nothing changed for non-high-contrast modes. Huzzah
- matching EuiCodeBlock visually
- only using 1px thick borders around items compared to steps - this is to match the corresponding EuiPanels better and also because the content is different + update VRT
… avatars - remove unnecessary `line-height` and `text-align: center` - flex centering already handles this automatically, and `line-height` is causing bizarre scrollbar issues - remove unnecessary overflow direction in favor of hiding overflow in all directions - there is no scenario in which we would want avatar content to be visible outside the circle - syntax - simplify logical sizing, replace calc with `mathWithUnits` - reran VRT, no changes
- add colored borders to update event types - remove duplicate panel borders in headers - add high contrast story that shows more edge cases
mgadewoll
approved these changes
Dec 12, 2024
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
cee-chen
added a commit
that referenced
this pull request
Dec 12, 2024
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 14, 2025
12 tasks
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 18, 2025
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 18, 2025
mgadewoll
pushed a commit
to mgadewoll/eui
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
Basically all the components that have some kind of vertical/horizontal timeline UI to them. Also cleaned up some CSS (particularly around steps focus outlines/box shadows) and docs along the way.
QA
Components should also have VRT screenshots added - feel free to refer to those.
EuiSteps
EuiTimeline
EuiCommentList
General checklist
and screenreader modes- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Checked in mobile